Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spec.swift_version #204

Merged
merged 1 commit into from
Apr 26, 2019
Merged

fix spec.swift_version #204

merged 1 commit into from
Apr 26, 2019

Conversation

weakfl
Copy link
Contributor

@weakfl weakfl commented Apr 23, 2019

Checklist for this pull request

  • I have read the guidelines for contributing.
  • I have updated README.md, describing the new feature I'm adding (if applicable).
  • I have checked that my code additions did fail neither code linting checks nor unit/UI test.

Description

swift_version must be set to 5.0 instead of 5, otherwise Xcode will still show the Instructions.framework target as available for conversion to Swift 5...

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #204 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #204   +/-   ##
======================================
  Coverage    81.8%   81.8%           
======================================
  Files          32      32           
  Lines        1962    1962           
======================================
  Hits         1605    1605           
  Misses        357     357
Flag Coverage Δ
#ios 81.8% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98a882d...0fcd9fc. Read the comment docs.

@ephread
Copy link
Owner

ephread commented Apr 23, 2019

Thanks @weakfl! That's a good catch, can you also update InstructionsAppExtensions.podspec?

@weakfl
Copy link
Contributor Author

weakfl commented Apr 24, 2019

Thanks @weakfl! That's a good catch, can you also update InstructionsAppExtensions.podspec?

Thanks, missed that one. Now fixed as well.

@ephread ephread merged commit 7c5d301 into ephread:master Apr 26, 2019
@ephread
Copy link
Owner

ephread commented Apr 26, 2019

Awesome, thanks! I'll make a new release this week-end.

@weakfl weakfl deleted the fix-podspec branch April 28, 2019 12:17
Tonbouy pushed a commit to Tonbouy/Instructions that referenced this pull request Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants