feat: Add Makefile #181
Merged
feat: Add Makefile #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielVoogsgerd
force-pushed
the
makefile
branch
from
beca5a1
to
6533970
Compare
I opted for Makefile here as it is ubiquitous and I hope the limitations of the language can keep us from creating overly complex build systems.
DanielVoogsgerd
force-pushed
the
makefile
branch
from
6533970
to
ca06895
Compare
|
Looks good to me! Been I while since I did proper Makefiles but I think it makes sense. So I'm all for pushing this ASAP. It looks like you're not replacing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opted for Makefile here as it is ubiquitous and I hope the limitations of the language can keep us from creating overly complex build systems.
@Lut99: Let me know what you think.
This is draft material, please review thoroughly; however due to the broken nature of our current make file, I would lean to merging as soon as this works for you too.
I rather have something that kinda works and me sending another PR, than having to tell people to run an old version.
fixes: #172, fixes: #149