Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement size-based filters using FeroxFilter trait #132

Merged
merged 6 commits into from
Nov 19, 2020

Conversation

epi052
Copy link
Owner

@epi052 epi052 commented Nov 19, 2020

Landing a Pull Request (PR)

Long form explanations of most of the items below can be found in the CONTRIBUTING guide.

Branching checklist

Static analysis checks

  • All rust files are formatted using cargo fmt
  • All clippy checks pass when running cargo clippy --all-targets --all-features -- -D warnings -A clippy::unnecessary_unwrap
  • All existing tests pass

Documentation

  • New code is documented using doc comments
  • Documentation about your PR is included in the README, as needed

Additional Tests

  • New code is unit tested
  • New code is integration tested, as needed
  • New tests pass

@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #132 (b1b9ea7) into master (db88e16) will increase coverage by 0.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
+ Coverage   94.25%   94.64%   +0.38%     
==========================================
  Files          12       12              
  Lines        1951     2036      +85     
==========================================
+ Hits         1839     1927      +88     
+ Misses        112      109       -3     
Impacted Files Coverage Δ
src/filters.rs 94.64% <100.00%> (+13.01%) ⬆️
src/main.rs 90.74% <100.00%> (+0.48%) ⬆️
src/scanner.rs 93.31% <100.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db88e16...b1b9ea7. Read the comment docs.

@epi052 epi052 merged commit dc10a56 into master Nov 19, 2020
@epi052 epi052 deleted the reimplement-size-filters-using-filter-trait branch November 19, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Dynamically tuning concurrency/connection limit or bailing after n connection failures
1 participant