Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add structured log output #133

Merged
merged 14 commits into from
Nov 25, 2020
Merged

add structured log output #133

merged 14 commits into from
Nov 25, 2020

Conversation

epi052
Copy link
Owner

@epi052 epi052 commented Nov 21, 2020

closes #124

Landing a Pull Request (PR)

Long form explanations of most of the items below can be found in the CONTRIBUTING guide.

Branching checklist

Static analysis checks

  • All rust files are formatted using cargo fmt
  • All clippy checks pass when running cargo clippy --all-targets --all-features -- -D warnings -A clippy::deref_addrof
  • All existing tests pass

Documentation

  • New code is documented using doc comments
  • Documentation about your PR is included in the README, as needed

Additional Tests

  • New code is unit tested
  • New code is integration tested, as needed
  • New tests pass

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #133 (2be2da4) into master (3881789) will decrease coverage by 0.08%.
The diff coverage is 98.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
- Coverage   93.79%   93.71%   -0.09%     
==========================================
  Files          13       13              
  Lines        2208     2179      -29     
==========================================
- Hits         2071     2042      -29     
  Misses        137      137              
Impacted Files Coverage Δ
src/scan_manager.rs 88.47% <ø> (ø)
src/heuristics.rs 91.15% <92.30%> (-2.97%) ⬇️
src/config.rs 96.40% <98.21%> (+0.23%) ⬆️
src/banner.rs 99.70% <100.00%> (+<0.01%) ⬆️
src/logger.rs 100.00% <100.00%> (+2.94%) ⬆️
src/main.rs 90.68% <100.00%> (-0.06%) ⬇️
src/parser.rs 100.00% <100.00%> (ø)
src/reporter.rs 88.88% <100.00%> (-1.77%) ⬇️
src/scanner.rs 92.06% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3881789...2be2da4. Read the comment docs.

@epi052 epi052 merged commit 4c39944 into master Nov 25, 2020
@epi052 epi052 deleted the 124-structured-log-output branch November 25, 2020 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant