Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow CLI args to work w/ --resume-from #150

Merged
merged 4 commits into from
Dec 9, 2020

Conversation

epi052
Copy link
Owner

@epi052 epi052 commented Dec 8, 2020

closes #151

Branching checklist

  • There is an issue associated with your PR (bug, feature, etc.. if not, create one)
  • Your PR description references the associated issue (i.e. fixes #123456)
  • Code is in its own branch
  • Branch name is related to the PR contents
  • PR targets master

Static analysis checks

  • All rust files are formatted using cargo fmt
  • All clippy checks pass when running cargo clippy --all-targets --all-features -- -D warnings -A clippy::deref_addrof
  • All existing tests pass

Documentation

  • New code is documented using doc comments
  • Documentation about your PR is included in the README, as needed

Additional Tests

  • New code is unit tested
  • New code is integration tested, as needed
  • New tests pass

@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #150 (3caa8d2) into master (6c779bd) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   93.32%   93.37%   +0.05%     
==========================================
  Files          13       13              
  Lines        2561     2583      +22     
==========================================
+ Hits         2390     2412      +22     
  Misses        171      171              
Impacted Files Coverage Δ
src/main.rs 91.80% <ø> (ø)
src/parser.rs 100.00% <ø> (ø)
src/scan_manager.rs 86.25% <ø> (ø)
src/config.rs 96.95% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c779bd...3caa8d2. Read the comment docs.

@epi052 epi052 changed the title feature appears to be working; tests passing allow CLI args to work w/ --resume-from Dec 9, 2020
@epi052 epi052 merged commit 0ea798e into master Dec 9, 2020
@epi052 epi052 deleted the allow-cli-override-resume-from branch December 9, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Allow CLI args to work in conjunction with --resume-from
1 participant