From b1bfae01f2b672dba8c7c335711d9351a465d7ec Mon Sep 17 00:00:00 2001
From: Maksim Nedoshev <m0ksem1337@gmail.com>
Date: Fri, 7 Jul 2023 13:59:38 +0300
Subject: [PATCH] fix(#3577): introduce useTeleported composable (#3578)

* fix(#3577): introduce useTeleported composable

* chore(docs): update modal demo

* fix(time-input): open on click

* chore(docs): change button in example to primary

* fix(dropdown): close on keyboard only focus outside
---
 .../modal/examples/NestedModals.vue           | 21 ++++++-
 .../src/components/va-dropdown/VaDropdown.vue |  6 +-
 .../src/components/va-modal/VaModal.demo.vue  | 14 ++++-
 .../ui/src/components/va-modal/VaModal.vue    |  6 +-
 .../components/va-time-input/VaTimeInput.vue  |  1 +
 packages/ui/src/composables/index.ts          |  1 +
 .../ui/src/composables/useClickOutside.ts     | 18 ++++--
 .../ui/src/composables/useFocusOutside.ts     | 63 ++++++++++++++-----
 packages/ui/src/composables/useTeleported.ts  | 37 +++++++++++
 9 files changed, 139 insertions(+), 28 deletions(-)
 create mode 100644 packages/ui/src/composables/useTeleported.ts

diff --git a/packages/docs/page-config/ui-elements/modal/examples/NestedModals.vue b/packages/docs/page-config/ui-elements/modal/examples/NestedModals.vue
index ee00b355ed..b29d2a23f9 100644
--- a/packages/docs/page-config/ui-elements/modal/examples/NestedModals.vue
+++ b/packages/docs/page-config/ui-elements/modal/examples/NestedModals.vue
@@ -13,22 +13,27 @@
         Nested Modal
       </h3>
 
-      <va-date-input prevent-overflow />
+      <va-date-input
+        v-model="date"
+        outline
+      />
 
       <p class="va-text-secondary opacity-50">
         This example shows how overlapping modals work after you click save.
       </p>
     </div>
 
-    <div class="flex justify-end mt-2">
+    <div class="flex justify-end mt-2 gap-2">
       <va-button
         preset="secondary"
         color="secondary"
-        class="mr-2"
         @click="hide()"
       >
         Cancel
       </va-button>
+      <va-button preset="primary" @click="setDefault">
+        Set default
+      </va-button>
       <va-button
         @click="showSecondModal = !showSecondModal"
       >
@@ -51,7 +56,17 @@ export default {
     return {
       showFirstModal: false,
       showSecondModal: false,
+      date: new Date(),
     };
   },
+  methods: {
+    setDefault() {
+      this.date = new Date();
+      this.$vaToast.init({
+        message: 'Date was set to default',
+        color: '#222222',
+      })
+    }
+  }
 };
 </script>
diff --git a/packages/ui/src/components/va-dropdown/VaDropdown.vue b/packages/ui/src/components/va-dropdown/VaDropdown.vue
index 7bd73eb60e..8c6a52a866 100644
--- a/packages/ui/src/components/va-dropdown/VaDropdown.vue
+++ b/packages/ui/src/components/va-dropdown/VaDropdown.vue
@@ -34,6 +34,7 @@ import { DropdownOffsetProp } from './types'
 import { useDropdown } from './hooks/useDropdown'
 import { warn } from '../../utils/console'
 import { useFocusOutside } from '../../composables/useFocusOutside'
+import { useTeleported } from '../../composables/useTeleported'
 
 export default defineComponent({
   name: 'VaDropdown',
@@ -194,7 +195,7 @@ export default defineComponent({
       if (props.closeOnFocusOutside && valueComputed.value) {
         emitAndClose('focus-outside', props.closeOnFocusOutside)
       }
-    })
+    }, { onlyKeyboard: true })
 
     const anchorComputed = computed(() => {
       return cursorAnchor.value || anchor.value
@@ -219,6 +220,7 @@ export default defineComponent({
 
     return {
       ...useTranslation(),
+      ...useTeleported(),
       anchor,
       anchorClass,
       floating,
@@ -239,6 +241,7 @@ export default defineComponent({
       ref: 'floating',
       class: 'va-dropdown__content-wrapper',
       style: this.floatingStyles,
+      ...this.teleportedAttrs,
       ...this.floatingListeners,
     })
 
@@ -250,6 +253,7 @@ export default defineComponent({
       'aria-label': this.tp(this.$props.ariaLabel),
       'aria-disabled': this.$props.disabled,
       'aria-expanded': !!this.showFloating,
+      ...this.teleportFromAttrs,
       ...this.$attrs,
     })
 
diff --git a/packages/ui/src/components/va-modal/VaModal.demo.vue b/packages/ui/src/components/va-modal/VaModal.demo.vue
index a66eee1bbf..e9a7afcd33 100644
--- a/packages/ui/src/components/va-modal/VaModal.demo.vue
+++ b/packages/ui/src/components/va-modal/VaModal.demo.vue
@@ -364,6 +364,15 @@
 
       <va-modal v-model="showBeforeHideModal" :message="message" :beforeClose="beforeClose" />
     </VbCard>
+    <VbCard title="closeOutside">
+      <button @click="showModalCloseOutside = !showModalCloseOutside">
+        Show modal
+      </button>
+
+      <va-modal v-model="showModalCloseOutside">
+        <VaDateInput />
+      </va-modal>
+    </VbCard>
   </VbDemo>
 </template>
 
@@ -373,9 +382,10 @@ import { VaButton } from '../va-button'
 import { VaCollapse } from '../va-collapse'
 import { VaInput } from '../va-input'
 import { VaDatePicker } from '../va-date-picker'
+import { VaDateInput } from '../va-date-input'
 
 export default {
-  components: { VaModal, VaButton, VaCollapse, VaInput, VaDatePicker },
+  components: { VaModal, VaButton, VaCollapse, VaInput, VaDatePicker, VaDateInput },
   data () {
     return {
       showModalSizeSmall: false,
@@ -411,6 +421,8 @@ export default {
       showModalFocusTrap1: false,
       showModalFocusTrap2: false,
       showBeforeHideModal: false,
+      showModalCloseOutside: false,
+      c: false,
       message: this.$vb.lorem(),
       longMessage: this.$vb.lorem(5000),
       collapseValue: false,
diff --git a/packages/ui/src/components/va-modal/VaModal.vue b/packages/ui/src/components/va-modal/VaModal.vue
index 42c673eb61..eedeccf6ae 100644
--- a/packages/ui/src/components/va-modal/VaModal.vue
+++ b/packages/ui/src/components/va-modal/VaModal.vue
@@ -7,7 +7,7 @@
     :aria-labelledby="title"
     :class="$props.anchorClass"
   >
-    <div v-if="$slots.anchor" class="va-modal__anchor">
+    <div v-if="$slots.anchor" class="va-modal__anchor" v-bind="teleportFromAttrs">
       <slot name="anchor" v-bind="slotBind" />
     </div>
 
@@ -17,7 +17,7 @@
         :isTransition="!$props.withoutTransitions"
         appear
         :duration="300"
-        v-bind="$attrs"
+        v-bind="{ ...$attrs, ...teleportedAttrs }"
         @beforeEnter="onBeforeEnterTransition"
         @afterEnter="onAfterEnterTransition"
         @beforeLeave="onBeforeLeaveTransition"
@@ -140,6 +140,7 @@ import {
   useTranslation,
   useClickOutside,
   useDocument,
+  useTeleported,
 } from '../../composables'
 
 import { VaButton } from '../va-button'
@@ -357,6 +358,7 @@ export default defineComponent({
       computedOverlayStyles,
       slotBind: { show, hide, toggle, cancel, ok },
       ...publicMethods,
+      ...useTeleported(),
     }
   },
 })
diff --git a/packages/ui/src/components/va-time-input/VaTimeInput.vue b/packages/ui/src/components/va-time-input/VaTimeInput.vue
index d049a84e26..800e68eb7c 100644
--- a/packages/ui/src/components/va-time-input/VaTimeInput.vue
+++ b/packages/ui/src/components/va-time-input/VaTimeInput.vue
@@ -11,6 +11,7 @@
         class="va-time-input__anchor"
         :style="cursorStyleComputed"
         v-bind="computedInputWrapperProps"
+        @click.stop="toggleDropdown"
       >
         <template #default>
           <input
diff --git a/packages/ui/src/composables/index.ts b/packages/ui/src/composables/index.ts
index 9d0f65d13d..fd0de6db8c 100644
--- a/packages/ui/src/composables/index.ts
+++ b/packages/ui/src/composables/index.ts
@@ -67,3 +67,4 @@ export * from './useReactiveComputed'
 export * from './useIcon'
 export * from './useGlobalConfig'
 export * from './usePlacementAliases'
+export * from './useTeleported'
diff --git a/packages/ui/src/composables/useClickOutside.ts b/packages/ui/src/composables/useClickOutside.ts
index a5a4214320..cb956eb769 100644
--- a/packages/ui/src/composables/useClickOutside.ts
+++ b/packages/ui/src/composables/useClickOutside.ts
@@ -2,6 +2,7 @@ import { Ref, unref } from 'vue'
 
 import { useCaptureEvent } from './useCaptureEvent'
 import { extractHTMLElement } from './useHTMLElement'
+import { findTeleportedFrom } from './useTeleported'
 
 const checkIfElementChild = (parent: HTMLElement, child: HTMLElement | null | undefined): boolean => {
   if (!child) { return false }
@@ -23,11 +24,18 @@ export const useClickOutside = (elements: MaybeArray<MaybeRef<HTMLElement | unde
       return
     }
 
-    const isClickInside = safeArray(elements)
-      .some((element) => {
-        const el = extractHTMLElement(unref(element))
-        return el && checkIfElementChild(el, clickTarget)
-      })
+    // Handle floating UI teleport
+    const teleportParent = findTeleportedFrom(clickTarget)
+
+    const isClickInside = safeArray(elements).some((element) => {
+      const el = extractHTMLElement(unref(element))
+
+      if (!el) { return false }
+
+      if (!teleportParent) { return checkIfElementChild(el, clickTarget) }
+
+      return checkIfElementChild(el, clickTarget) || checkIfElementChild(el, teleportParent)
+    })
 
     if (!isClickInside) { cb(clickTarget) }
   })
diff --git a/packages/ui/src/composables/useFocusOutside.ts b/packages/ui/src/composables/useFocusOutside.ts
index b3b16e3967..e61bb18fe1 100644
--- a/packages/ui/src/composables/useFocusOutside.ts
+++ b/packages/ui/src/composables/useFocusOutside.ts
@@ -2,34 +2,65 @@ import { Ref, unref } from 'vue'
 
 import { useCaptureEvent } from './useCaptureEvent'
 import { extractHTMLElement } from './useHTMLElement'
+import { useEvent } from './useEvent'
 
-const checkIfElementChild = (parent: HTMLElement, child: HTMLElement | Window | null | undefined): boolean => {
-  if (!child) { return false }
-  if (child instanceof Window) { return false }
-  if (child.parentElement === parent) { return true }
+const checkIfElementChild = (
+  parent: HTMLElement,
+  child: HTMLElement | Window | null | undefined,
+): boolean => {
+  if (!child) {
+    return false
+  }
+  if (child instanceof Window) {
+    return false
+  }
+  if (child.parentElement === parent) {
+    return true
+  }
 
   return parent.contains(child)
 }
 
-type MaybeRef<T> = T | Ref<T>
-type MaybeArray<T> = T | T[]
+type MaybeRef<T> = T | Ref<T>;
+type MaybeArray<T> = T | T[];
 
-const safeArray = <T>(a: MaybeArray<T>) => Array.isArray(a) ? a : [a]
+const safeArray = <T>(a: MaybeArray<T>) => (Array.isArray(a) ? a : [a])
+
+export const useFocusOutside = (
+  elements: MaybeArray<MaybeRef<HTMLElement | undefined>>,
+  cb: (el: HTMLElement) => void,
+  options: {
+    onlyKeyboard?: boolean;
+  } = {},
+) => {
+  let previouslyClicked = false
+  if (options.onlyKeyboard) {
+    useEvent('mousedown', (e) => {
+      previouslyClicked = true
+      setTimeout(() => {
+        previouslyClicked = false
+      }, 200)
+    }, true)
+  }
+
+  useEvent('focus', (event) => {
+    if (options.onlyKeyboard && previouslyClicked) {
+      return
+    }
 
-export const useFocusOutside = (elements: MaybeArray<MaybeRef<HTMLElement | undefined>>, cb: (el: HTMLElement) => void) => {
-  useCaptureEvent('focus', (event: MouseEvent) => {
     const focusTarget = event.target as HTMLElement
 
     if ((event.target as HTMLElement).shadowRoot) {
       return
     }
 
-    const isFocusInside = safeArray(elements)
-      .some((element) => {
-        const el = extractHTMLElement(unref(element))
-        return el && checkIfElementChild(el, focusTarget)
-      })
+    const isFocusInside = safeArray(elements).some((element) => {
+      const el = extractHTMLElement(unref(element))
+      return el && checkIfElementChild(el, focusTarget)
+    })
 
-    if (!isFocusInside) { cb(focusTarget) }
-  })
+    if (!isFocusInside) {
+      cb(focusTarget)
+    }
+  }, true)
 }
diff --git a/packages/ui/src/composables/useTeleported.ts b/packages/ui/src/composables/useTeleported.ts
new file mode 100644
index 0000000000..e09914bf3d
--- /dev/null
+++ b/packages/ui/src/composables/useTeleported.ts
@@ -0,0 +1,37 @@
+import { useCurrentComponentId } from './useCurrentComponentId'
+
+export const TELEPORT_FROM_ATTR = 'data-va-teleported-from'
+export const TELEPORT_ATTR = 'data-va-teleported'
+
+export const findTeleportedFrom = (el: HTMLElement | undefined | null): HTMLElement | null => {
+  if (!el) { return null }
+
+  const teleportId = el.getAttribute(TELEPORT_ATTR)
+
+  if (teleportId === null) { return findTeleportedFrom(el.parentElement) }
+
+  return document.querySelector<HTMLElement>(`[${TELEPORT_FROM_ATTR}="${teleportId}"]`)
+}
+
+/**
+ * Used in components, which have something to do with Teleport.
+ * You need to add `teleportFromAttrs` to the root element of the component,
+ * and `teleportedAttrs` to the element, which is teleported.
+ *
+ * This way you can find the original element, which was teleported from.
+ *
+ * @notice it is used in `useClickOutside` to track from where teleported originated from.
+ */
+export const useTeleported = () => {
+  const componentId = useCurrentComponentId()
+
+  return {
+    teleportFromAttrs: {
+      [TELEPORT_FROM_ATTR]: componentId,
+    },
+    teleportedAttrs: {
+      [TELEPORT_ATTR]: componentId,
+    },
+    findTeleportedFrom,
+  }
+}