Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange grid logic #1287

Closed
Tracked by #1174
m0ksem opened this issue Nov 30, 2021 · 4 comments · Fixed by #2745
Closed
Tracked by #1174

Strange grid logic #1287

m0ksem opened this issue Nov 30, 2021 · 4 comments · Fixed by #2745
Assignees
Labels
blocked Blocked by another issue BUG Something isn't working

Comments

@m0ksem
Copy link
Collaborator

m0ksem commented Nov 30, 2021

We have two classes:

d-flex
flex

md6 or sm12 classes don't work without flex class.

flex class makes nothing by it self.

It can be confused and also break some frameworks like tailwind.

@m0ksem m0ksem added the BUG Something isn't working label Nov 30, 2021
@asvae
Copy link
Member

asvae commented Dec 1, 2021

Tailwind shouldn't be an issue, as if you use tailwind helpers you won'd use vuestic helpers.

@m0ksem
Copy link
Collaborator Author

m0ksem commented Dec 1, 2021

Tailwind shouldn't be an issue, as if you use tailwind helpers you won'd use vuestic helpers.

Yes, since we have tree-shakable CSS user can remove our grid from bundle. Anyway, these two classes can make smby confused.

@asvae asvae mentioned this issue Dec 2, 2021
8 tasks
@asvae
Copy link
Member

asvae commented Dec 2, 2021

Moved to another issue - we plan to rework CSS helpers

@asvae asvae modified the milestones: 1.4.0, next Dec 30, 2021
@asvae asvae added the blocked Blocked by another issue label Dec 30, 2021
@asvae
Copy link
Member

asvae commented Dec 30, 2021

Let's handle this after investigation is done in scope of #1222

@asvae asvae added the groomed label Dec 30, 2021
@asvae asvae removed the groomed label Jun 8, 2022
@aluarius aluarius self-assigned this Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by another issue BUG Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants