Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color helpers #1425

Closed
6 tasks
Tracked by #1174
asvae opened this issue Jan 18, 2022 · 3 comments · Fixed by #3115
Closed
6 tasks
Tracked by #1174

Color helpers #1425

asvae opened this issue Jan 18, 2022 · 3 comments · Fixed by #3115
Assignees
Labels
d3: medium No cheats. Monsters a bit faster. docs packages/docs partially implemented Issue is checked and needs some additional work v2: nice to have This will make Vuestic feel better

Comments

@asvae
Copy link
Member

asvae commented Jan 18, 2022

Should be added as Optional Service
Depends on Colors Service

Usage example:

<span class="text--primary bg--secondary">primary secondary</span>

We had this functionality before, but it disappeared mysteriously 🤪.

  • Service should generate CSS dynamically based on colors config. I suggest you look into prior implementation (couple years back should be enough). The idea is that we attach styles to head, then replace that block on colors change. Old implementation was well implemented.
  • should support only text and background: text--primary, bg--secondary
  • Should have no configuration
  • CSS helpers should rely on CSS variables (that are part of Colors Service).
  • Document Color helpers as a separate page in Services category. Add installation instructions.
  • There are still some places with text--primary, these do nothing and we need to fix these (remove or make do something).
@asvae asvae added good first issue Right issue if you're new to vuestic team discussion Feedback wanted labels Jan 18, 2022
@asvae asvae mentioned this issue Jan 18, 2022
8 tasks
@asvae asvae added groomed and removed team discussion Feedback wanted labels Jan 20, 2022
@m0ksem
Copy link
Collaborator

m0ksem commented Jan 26, 2022

Here we have a PR: #936 (partially implemented)

@m0ksem m0ksem assigned m0ksem and unassigned m0ksem Mar 30, 2022
@m0ksem
Copy link
Collaborator

m0ksem commented May 24, 2022

  • Must be separated plugin (defineVuesticPlugin)
  • Have a config (default and user must be able to extend it)
  • Custom prefix (or no prefix at all)

Example config:

export let helperConfigValues: HelperConfig[] = [
  {
    stylePrefix: 'bg',
    styleProperty: 'background-color',
  },
  {
    stylePrefix: 'text',
    styleProperty: ['color', 'fill'],
  },
]

@m0ksem m0ksem assigned rustem-nasyrov and unassigned legit1One May 24, 2022
@asvae asvae removed the groomed label Jun 8, 2022
@m0ksem m0ksem added partially implemented Issue is checked and needs some additional work docs packages/docs labels Feb 22, 2023
@m0ksem
Copy link
Collaborator

m0ksem commented Feb 22, 2023

It is implemented. Need docs. Also, need to think how we can integrate it with Tailwind. I've made it with UnoCSS.

@m0ksem m0ksem added d3: medium No cheats. Monsters a bit faster. v2: nice to have This will make Vuestic feel better labels Feb 22, 2023
@rustem-nasyrov rustem-nasyrov moved this from To Do to In Progress in 1) 26.02-10.03 Mar 1, 2023
@asvae asvae removed the good first issue Right issue if you're new to vuestic label Mar 1, 2023
@rustem-nasyrov rustem-nasyrov moved this from In Progress to QA / Review in 1) 26.02-10.03 Mar 2, 2023
@github-project-automation github-project-automation bot moved this from QA / Review to Done in 1) 26.02-10.03 Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d3: medium No cheats. Monsters a bit faster. docs packages/docs partially implemented Issue is checked and needs some additional work v2: nice to have This will make Vuestic feel better
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants