-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct VaSelect keyboard navigation #1783
Comments
Take a notice that VaTimePicker also must select option on space, instead of scroll. OR do we want to change space to enter? Not sure here... |
Regarding enter/space usage I think best idea would be to stick to vanilla behavior, as that could be something that user expects. For vanilla select:
Yeah. That's a good one, matter of convenience for selects with few options. We can definitely implement it.
A matter of convention. It might make sense not to close picker on enter (select does close). |
Let's use enter as select option action. Looks like selecting only with space, it is macOS only specific behavior. More information can be found here: https://www.w3.org/TR/wai-aria-practices/#combobox-keyboard-interaction |
I support this -
Or we could add
If depends on
Yeah on windows it opens by "Enter" press. |
Since we support multiple select, it is suggested that UP and DOWN keys must open dropdown. So this issue probably need to be closed. |
Enter usually used for submit action in form. I would rather just use space to open select. Pressing enter on any component could submit my form.
Also, up and down buttons often used not for dropdown opening, but switching between options without opening dropdown.
Originally posted by @m0ksem in #1778 (comment)
The text was updated successfully, but these errors were encountered: