Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of va-button__content #3165

Open
m0ksem opened this issue Mar 13, 2023 · 4 comments
Open

get rid of va-button__content #3165

m0ksem opened this issue Mar 13, 2023 · 4 comments
Labels
d2: easy Recomended mode for new, but mature players research Requires research v3: wish to have This is something user want, but can live without it

Comments

@m0ksem
Copy link
Collaborator

m0ksem commented Mar 13, 2023

Can't we make button just using button tag?
@m0ksem m0ksem added the team discussion Feedback wanted label Mar 13, 2023
@asvae
Copy link
Member

asvae commented Mar 16, 2023

Maybe we can move this to research? I'm not seeing much to discuss.

@asvae asvae added the research Requires research label Mar 16, 2023
@asvae
Copy link
Member

asvae commented Mar 16, 2023

image

We agreed this needs a bit of research, but probable choice would be to move icons outside of span.
Another option is to ask @damirJa, who did some work on buttons and might know some info.

@asvae asvae added d2: easy Recomended mode for new, but mature players v3: wish to have This is something user want, but can live without it and removed team discussion Feedback wanted labels Mar 16, 2023
@asvae
Copy link
Member

asvae commented Mar 16, 2023

v3 because this sometimes breaks button formatting on size change

@m0ksem
Copy link
Collaborator Author

m0ksem commented Mar 16, 2023

Maybe closes #2704

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
d2: easy Recomended mode for new, but mature players research Requires research v3: wish to have This is something user want, but can live without it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asvae @m0ksem