Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish: va-virtual-scroller #3865

Open
Tracked by #3705
asvae opened this issue Sep 13, 2023 · 0 comments
Open
Tracked by #3705

Polish: va-virtual-scroller #3865

asvae opened this issue Sep 13, 2023 · 0 comments
Labels
d2: easy Recomended mode for new, but mature players v1: minor This might be helpful, but not really

Comments

@asvae
Copy link
Member

asvae commented Sep 13, 2023

  • Disabled prop doesn't function according to docs.
    • Here's what it says in docs Applies disabled style and removes all user interaction effects..
    • Right now it just shows all items instead of visible items subset.
    • I suggest we check other references to make sure that current implementation is a good idea. I wouldn't assume disable disables virtual scroll, but rather makes whole element inactive (but that's just me).
  • DifferentSizesAndMargins story is a bit too complex (even uses buttons for some reason). We can probably simplify it.
  • track-by is not tested properly and story has no visual hints whether it works or not.
@asvae asvae mentioned this issue Sep 13, 2023
77 tasks
@asvae asvae added d2: easy Recomended mode for new, but mature players v1: minor This might be helpful, but not really labels Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d2: easy Recomended mode for new, but mature players v1: minor This might be helpful, but not really
Projects
None yet
Development

No branches or pull requests

1 participant