Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal - CloseButton/close-button doesn't exist #3995

Open
LachlanBorwick opened this issue Nov 3, 2023 · 1 comment
Open

Modal - CloseButton/close-button doesn't exist #3995

LachlanBorwick opened this issue Nov 3, 2023 · 1 comment
Labels
d1: super easy Task for newbies. Players take half normal damage from monsters and the environment. docs packages/docs good first issue Right issue if you're new to vuestic v2: nice to have This will make Vuestic feel better

Comments

@LachlanBorwick
Copy link

LachlanBorwick commented Nov 3, 2023 •
edited by m0ksem
Loading

In the docs, you have an example of using the close button as a prop for a modal. But there are two issues:

  • In the example, you use "close-button", but in the prop's section, you specify "closeButton".
  • The API description doesn't exists either
@LachlanBorwick LachlanBorwick added the docs packages/docs label Nov 3, 2023
@m0ksem
Copy link
Collaborator

m0ksem commented Nov 3, 2023

Same missed description for showNestedOverlay.

@m0ksem m0ksem added good first issue Right issue if you're new to vuestic d1: super easy Task for newbies. Players take half normal damage from monsters and the environment. v2: nice to have This will make Vuestic feel better labels Nov 3, 2023
@ahmadJT ahmadJT mentioned this issue Apr 16, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
d1: super easy Task for newbies. Players take half normal damage from monsters and the environment. docs packages/docs good first issue Right issue if you're new to vuestic v2: nice to have This will make Vuestic feel better
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@m0ksem @LachlanBorwick