fix_dist -> fix_parameters #733
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 81258af is merged into main:
|
jamesmbaazam
reviewed
Aug 2, 2024
| @@ -11,6 +11,10 @@ | |||
| - The interface for defining delay distributions has been generalised to also cater for continuous distributions | |||
| - When defining probability distributions these can now be truncated using the `tolerance` argument | |||
|
|
|||
| ## Package changes | |||
|
|
|||
| - `fix_dist()` has been renamed to `fix_parameters()`. By @sbfnk in and reviewed by. | |||
There was a problem hiding this comment.
Suggested change
| - `fix_dist()` has been renamed to `fix_parameters()`. By @sbfnk in and reviewed by. | |
| - `fix_dist()` has been renamed to `fix_parameters()`. By @sbfnk in #733 and reviewed by @jamesmbaazam. |
jamesmbaazam
reviewed
Aug 2, 2024
| #' @param strategy Character; either "mean" (use the mean estimates of the | ||
| #' mean and standard deviation) or "sample" (randomly sample mean and | ||
| #' standard deviation from uncertainty given in the `<dist_spec>` | ||
| fix_parameters <- function(x, strategy = c("mean", "sample")) { |
There was a problem hiding this comment.
Suggested change
| fix_parameters <- function(x, strategy = c("mean", "sample")) { | |
| fix_dist <- function(x, strategy = c("mean", "sample")) { |
jamesmbaazam
reviewed
Aug 2, 2024
| #' standard deviation from uncertainty given in the `<dist_spec>` | ||
| fix_parameters <- function(x, strategy = c("mean", "sample")) { | ||
| lifecycle::deprecate_warn( | ||
| "1.6.0", "fix_parameters()", "fix_parameters()" |
There was a problem hiding this comment.
Suggested change
| "1.6.0", "fix_parameters()", "fix_parameters()" | |
| "1.6.0", "fix_dist()", "fix_parameters()" |
jamesmbaazam
reviewed
Aug 2, 2024
| @@ -108,7 +108,8 @@ reference: | |||
| - bound_dist | |||
| - collapse | |||
| - discretise | |||
| - fix_dist | |||
| - fix_parameters | |||
There was a problem hiding this comment.
Suggested change
| - fix_parameters |
jamesmbaazam
requested changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #715.
Initial submission checklist
devtools::test()anddevtools::check()).devtools::document()).lintr::lint_package()).After the initial Pull Request