Fix argument name in cfr_time_varying() documentation
#134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for catching this @joshwlambert. I've just corrected another typo (my own), and rephrased the explanation of the delay distribution which I think makes it clearer. Feel free to merge it once the fix is added and checks pass.
joshwlambert
changed the title
cfr_time_varying() documentationcfr_time_varying() documentation
|
Just nudging @joshwlambert on this. |
Co-authored-by: Pratik Gupte <pratikgupte16@gmail.com>
|
Thanks for the nudge @pratikunterwegs (or should I say Richard Thaler). I've made a small change to the doc as mentioned in the message above, and now all the checks pass so I'll merge this PR. |
|
Thanks @joshwlambert! Although I will point out that behavioural economics is somewhat on the ropes these days :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a possible typo in the documentation of
cfr_time_varying()which references what is maybe a previous version of thedelay_densityargument,epidist.NEWS.mdThis PR doesn't not contain any (functional) user-facing or breaking changes.