Add .github/settings.yml
#145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bisaloo
reviewed
Apr 18, 2024
| @@ -0,0 +1,22 @@ | |||
| repository: | |||
There was a problem hiding this comment.
It would be good if we can also set the GitHub Pages settings in accordance with our pkgdown workflow. Let's keep an eye on repository-settings/app#609.
| branches: | ||
| - name: main | ||
| # https://docs.github.com/en/rest/reference/repos#update-branch-protection | ||
| protection: |
There was a problem hiding this comment.
FYI:
We have discussed using required_linear_history: true with @bahadzie in the past but didn't come up with a satisfying solution.
The problem is that it will not remove the button "update branch" (implied: with a merge commit), but then block you from merging the PR is you clicked this button.
Based on #145 (comment)
Bisaloo
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently installed the GitHub settings application to the
epiverse-traceorganization. This PR adds the relevant.github/settings.ymlfile that will then become part of any future repo's built on the template.This PR must be reviewed, as it also has consequences for this repository that need to be resolved first (see below). The settings are my first best guess as to what we want, based on existing settings from the repositories that I investigated. These are only a departure point for our discussion here 💙
Questions