Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tracetheme dimensions and theme #146

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Use tracetheme dimensions and theme #146

wants to merge 6 commits into from

Conversation

Bisaloo
Copy link
Member

@Bisaloo Bisaloo commented Apr 18, 2024

Fix #131

@Bisaloo Bisaloo requested a review from joshwlambert April 18, 2024 12:37
@joshwlambert
Copy link
Member

CI workflows are failing, does the tracetheme package need to be added to Remotes in DESCRIPTION for it to be correctly installed in setup-r-dependencies?

@Bisaloo
Copy link
Member Author

Bisaloo commented Apr 22, 2024

I forgot about r-lib/actions#656.

We cannot put it in Remotes: because that would affect our ability to put packages on CRAN.

Two solutions:

  • modify the pkgdown.yaml workflows to add our r-universe as a source repo
  • add tracetheme in Config/Needs/website:, which will work out of the box but may mean that we see difficult results locally if tracetheme is not installed (EDIT: that would only fix the pkgdown wofklow, not the others)

What do you think?

@joshwlambert
Copy link
Member

My initial preference is to add it to Config/Needs/website:, because functions from it are explicitly namespaced in the package, having it stated in the DESCRIPTION file is, IMO, more familiar, and is probably where someone would look for the dependency. However, I don't have a strong preference either way and both would satisfy to get this PR merged.

Another option would be to put tracetheme on CRAN, even if not intended for wider use, it may ease Epiverse development, but I understand that that is not a short term solution to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use {tracetheme} plotting default dimensions
2 participants