Add support to show prometheus metrics when rbac is enabled in airflow #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phanindhra876
changed the title
|
Can anyone have a look at this PR? |
|
@phani8996 sorry for the delay, we’ll get to it today/tomorrow |
|
@phani8996 can you please update your branch from current master? this way we could see whether tests in Travis are passing |
This enables prometheus metrics view on airflow when rbac is enabled. Support for plugins in rbac is not available in release 1.10. This will be available in dev/future releases of airflow.
|
@elephantum Can you help me with testing. I have no idea what's failing the tests. |
|
@cleverCat подключись плз |
|
@phani8996 we're on it |
|
@phani8996 thanks again for your help, merged PR to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables prometheus metrics view on airflow when rbac is enabled.
Support for plugins in rbac is not available in release 1.10. This will be available in dev/future releases of airflow.