-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small improvements to ngl views of assemblies and interfaces #124
Comments
Another aspect to improve is the representation of core and rim residue side chains in interfaces: currently all residue atoms are shown, while the main chain atoms C, O and N (and main chain hydrogens when present) should be hidden. |
There is a 'sidechain' selector in NGL (http://arose.github.io/ngl/doc/#User_manual/Usage/Selection_language) |
Any reason not to show waters? I like that they can be shown quite nicely with NGL. They can help interpreting things. |
@josemduarte the rationale here, in addition to having a less crowded view, is that the chains of assemblies are shown in cartoon mode, which provides an overall idea of the fold and secondary structure, but no atomic details, while water molecules (if accurate) are at the atomic detail level and help interpretation the most if one can see their interaction details with the surface. The user wanting to do that can download the coordinates for detailed examination with a local viewer (most likely looking at water structure by displaying the protein in full-atom representation). |
This relates to the issue of creating some user interface for controlling the NGL display, I've now created a new issue for that: #126 . Let's go for default without waters and having the option to show them in a button. |
The sidechain display now appears to work OK and to be clean with the rare exception of C-terminal core or rim residues, where the OXT atom is considered sidechain by NGL and appears as a detached sphere (e.g. in interface 3 of 2trx). See nglviewer/ngl#145. |
This looks good now, I'll close |
According to nglviewer/ngl#145 we should use the 'sidechainAttached' selector. |
We also need to update to the newest NGL release (tag 0.7.1a). The default path (from rawgit) should be: https://cdn.rawgit.com/arose/ngl/v0.7.1a/js/build/ngl.embedded.min.js |
TODO still - update the ngl.embedded.min.js to the lastest (above link is out of date) but need to test it first. |
As of today, the latest release is 0.9.3, see https://github.com/arose/ngl/releases/tag/v0.9.3 |
Currently ngl assembly views (but not interface views) display water molecules, which should not be the case.
Both for assemblies and interfaces the background should be white instead of black.
The 3D Viewer selector still indicates 3Dmol.js instead of NGL. Also the tooltip for the selector should be modified accordingly (saying NGL viewer).
The text was updated successfully, but these errors were encountered: