One thing this doesn't do, is support creating 1 DX Gateway with multiple connections attached, if there is a count for the connections it will create separate DX Gateways for each connection which isn't really what's wanted I think for adjusting capacity of connections. This behavior is consistent though with the create vgw option.

Thanks for the issue and

Sorry - my corgi is trying to play, mouthed my typing hand, and accidentally closed the PR 😅 🐕

Thanks for the issue and PR! This looks good overall (plus terraform init and ... validate pass ✔️ ). We'll need to verify the functionality ahead of a merge which may take some time.

I should also mention that this module is currently based on the v3 ECX API Terraform resources, which are deprecated: equinix/terraform-provider-equinix#445 (cc @thogarty)

There has been some conversation about moving the examples/ from the Terraform provider repo into modules such as this one or refactoring modules such as this one to take advantage of a new central module (or revising https://github.com/equinix-labs/terraform-equinix-fabric-connection, which this module depends on).

Here is the AWS example based on the v4 Fabric API Terraform resources:
https://github.com/equinix/terraform-provider-equinix/tree/main/examples/fabric/v4/portConnectivity/aws

Thanks for the feedback! Let me know if we should make any more changes or if it should all be applied somehow differently to the newer API.