Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adding patches to fabricv4 for Terraform Provider Equinix migration to equinix-sdk-go #46

Merged
merged 8 commits into from
Apr 5, 2024
Merged

fix: Adding patches to fabricv4 for Terraform Provider Equinix migration to equinix-sdk-go #46

merged 8 commits into from
Apr 5, 2024

Conversation

thogarty
Copy link
Contributor

@thogarty thogarty commented Apr 1, 2024 •
edited
Loading

  • Removed additional properties from ServiceProfileAccessPointTypeVD to avoid unmarshal conflict with ServiceProfileAccessPointTypeCOLO because they're both in the anyOf property for ServiceProfileAccessPointType
  • Renamed CloudRouterPackageType to CloudRouterPostRequestPackage to avoid naming conflict for code generation. The first name would not create the correct model to be used for creating CloudRouters
  • Created PortResponse base model to be used for Port API Responses and then used in it the Port model so that Port could have required fields while PortResponse did not contain that restriction
  • Created SimplifiedAccountPortResponse model to account for Fabric Port API returning accounNumber and orgId as strings instead of int

@thogarty
Manual Spec Patch: Removing additionalProperties from ServiceProfileA…
8fc6276 
…ccessPointTypeVD to avoid Unmarshall match error with ServiceProfileAccessPointTypeCOLO
@thogarty
Code Generation for removing additionalProperties from ServiceProfile…
df3877c 
…AccessPointTypeVD
@thogarty
Manual Spec Patch: Renamed CloudRouterPackageType to CloudRouterPostR…
900bce0 
…equestPakcage to resolve code generation naming conflict error
@thogarty
Code generation for renaming CloudRouterPackageType to CloudRouterPos…
c4e50d2 
…tRequestPackage
@thogarty
Manual Spec Patch: Create PortResponse model which acts as base model…
2ceb681 
… for Port model. Resolves strict checking of required fields in response object
@thogarty
Code generation for creating PortResponse model as base object for Po…
e6478c9 
…rt model
@thogarty thogarty requested a review from a team as a code owner April 1, 2024 19:40
ctreatma
ctreatma approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@ctreatma ctreatma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thogarty
Copy link
Contributor Author

thogarty commented Apr 5, 2024

@ctreatma , I made a small change after approval. Fabric Port team is still accepting Port Request Account values as int. So needed to make sure I only updated the response. Wanted to alert you to that before merging.

@ctreatma ctreatma merged commit 4238767 into main Apr 5, 2024
3 checks passed
@ctreatma ctreatma deleted the equinix-sdk-go-migration branch April 5, 2024 19:40
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 5, 2024

This PR is included in version 0.35.1 🎉

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctreatma ctreatma ctreatma approved these changes

@srushti-patl srushti-patl Awaiting requested review from srushti-patl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thogarty @ctreatma