Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fabricv4 patch project response #58

Merged
merged 3 commits into from
May 7, 2024
Merged

fix: Fabricv4 patch project response #58

merged 3 commits into from
May 7, 2024

Conversation

thogarty
Copy link
Contributor

@thogarty thogarty commented May 6, 2024

  • Removed required field for projectId from project model to resolve customer issue with Terraform Provider
    • [Bug]: Error: no value given for required property projectId terraform-provider-equinix#657
    • Error is caused by Equinix Fabric API returning an empty project project: {} in the JSON response for PDS user accounts
    • Adding temporary patch until Equinix Fabric API teams remove the empty project from the API response
    • Does affect request models as well, but the API will return the error that project is required for those requests. Will revert as soon as we can

@thogarty thogarty requested a review from a team as a code owner May 6, 2024 21:48
srushti-patl
srushti-patl approved these changes May 7, 2024
View reviewed changes
Copy link

@srushti-patl srushti-patl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thogarty thogarty merged commit dd062b8 into main May 7, 2024
3 checks passed
@thogarty thogarty deleted the fabricv4_patch_project_response branch May 7, 2024 20:51
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024

This PR is included in version 0.39.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srushti-patl srushti-patl srushti-patl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thogarty @srushti-patl