Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yaml key/property validation in eraser_controller_manager_config #893

Open
jiashun0011 opened this issue Oct 16, 2023 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@jiashun0011
Copy link

jiashun0011 commented Oct 16, 2023

Describe the solution you'd like
Is that possible to add key/property validation check in eraser_controller_manager_config?

For example, if I have piece of configmap like

components:
  collector:
    enabled: true
    image:
      repo: mcr.microsoft.com/oss/eraser/collector
-     tag:v1.1.0request:
+     tag: v1.1.0
+   request:
      mem: 100Mi
      cpu: 1000m
    limit:
      mem: 500Mi
      # https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#how-pods-with-resource-limits-are-run
      cpu: 0

Customer used their own auto-gen tooling to generate eraser configmap while by mistake, a invalid key tag:v1.1.0request with null value was generated. Moreover, the mem and cpu changes supposed to be under request were put under image which caused eraser still use default request values.

If we have kinda validations to check those key/properties once config yaml was applied, report like

  • tag:v1.1.0request is an invalid key under image
  • men is an invalid key under image
  • cpu is an invalid key under image

then it must help us debug and find customer's configuration error earlier?

@jiashun0011 jiashun0011 added the enhancement New feature or request label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant