Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update packages.json #956

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

ashnamehrotra
Copy link
Contributor

What this PR does / why we need it:
Update packages.json with yarn upgrade --latest

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
@ashnamehrotra ashnamehrotra marked this pull request as draft January 18, 2024 00:16
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
@ashnamehrotra ashnamehrotra marked this pull request as ready for review January 18, 2024 20:57
@ashnamehrotra
Copy link
Contributor Author

had to temporarily change onBrokenLinks to warn, this issue is related facebook/docusaurus#9758

@sozercan
Copy link
Member

sozercan commented Jan 19, 2024

looks like there are a few broken links: https://github.com/eraser-dev/eraser/actions/runs/7575839168/job/20633351362?pr=956

opened #958

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashnamehrotra
Copy link
Contributor Author

ashnamehrotra commented Jan 19, 2024

looks like there are a few broken links: https://github.com/eraser-dev/eraser/actions/runs/7575839168/job/20633351362?pr=956

opened #958

I think the broken links are due to the docusaurus issue linked above, since the links have been fine before the upgrade. Is this still good to merge?

@ashnamehrotra ashnamehrotra merged commit ac614ff into eraser-dev:main Jan 22, 2024
93 checks passed
ashnamehrotra added a commit to ashnamehrotra/eraser that referenced this pull request Jan 25, 2024
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
@ashnamehrotra ashnamehrotra mentioned this pull request Jun 6, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants