Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up after manifest-source removal #11

Open
wrygiel opened this issue Nov 7, 2017 · 3 comments
Open

Clean up after manifest-source removal #11

wrygiel opened this issue Nov 7, 2017 · 3 comments
Labels

Comments

@wrygiel
Copy link
Contributor

wrygiel commented Nov 7, 2017

When manifest sources are removed, the data from its manifests is not removed from the manifest repository, but it seems that it should be.

@wrygiel wrygiel self-assigned this Nov 7, 2017
@wrygiel wrygiel added the bug label Nov 7, 2017
@wrygiel
Copy link
Contributor Author

wrygiel commented Nov 7, 2017

This problem will probably "solve itself" once this feature is implemented: erasmus-without-paper/ewp-specs-api-discovery#7

@wrygiel
Copy link
Contributor Author

wrygiel commented Jan 4, 2018

This problem will probably "solve itself" once this feature is implemented: erasmus-without-paper/ewp-specs-api-discovery#7

This is only partially true. When a <host> element is removed from an otherwise valid <manifest>, then it will also be removed from the catalogue. However, if the whole manifest is removed, it still won't work.

@wrygiel
Copy link
Contributor Author

wrygiel commented Jan 17, 2018

Today we have removed lots of SOPs manifest files from DEV Registry's manifest-sources.xml file. Here's what happened:

  • GOOD: All the removed manifests correctly disappeared from the catalogue.

  • BAD: Old copies were NOT removed from the repository. You can see it here - I believe this folder should have been made empty in this commit, but it wasn't.

  • BAD: The index.xml file also wasn't updated. I believe all SOP entries should have been removed in this commit, but weren't.

I won't have time to fix this issue before I leave the project, but hopefully these comments will help the future maintainers.

@wrygiel wrygiel changed the title Manifest-source removal does not work Clean up after manifest-source removal Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant