Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure of (non)personal contacts #1

Closed
kaiqu opened this issue Jan 3, 2017 · 6 comments
Closed

Structure of (non)personal contacts #1

kaiqu opened this issue Jan 3, 2017 · 6 comments

Comments

@kaiqu
Copy link

kaiqu commented Jan 3, 2017

Continuing the discussion in (the now closed) erasmus-without-paper/ewp-specs-api-institutions#8:

I think personal and non-personal contacts should be structurally different

You may be right. This is one of the issues I have delayed on purpose, because I'm still thinking about it. On one hand, clients might simply display all the contacts to the viewer (in this case, having one abstract contact "view" might be enough). On the other hand, other clients might want to store them to their databases (in this case, we need more precise structure). We will come back to this.

Ok. Maybe an attribute could differentiate?

It depends. If it turns out that this information has to be stored by the client in an actual PERSON table, then attribute might not be enough (we might need separate first name and last name fields).

This also touches another discussion we had about fact sheets, where the conclusion was that they should always be PDF URLs, to avoid security problems. Doesn't this apply to (at least non-personal) contacts as well, @wrygiel ?

@wrygiel
Copy link
Contributor

wrygiel commented Jan 4, 2017

This also touches another discussion we had about fact sheets, where the conclusion was that they should always be PDF URLs, to avoid security problems. Doesn't this apply to (at least non-personal) contacts as well, @wrygiel ?

It doesn't. Security issues we talked about in fact-sheets were related to displaying foreign (and possibly malicious) HTML in local web pages. The <contact> element does not allow HTML in any of the fields, so there are no such concerns here.

@kaiqu
Copy link
Author

kaiqu commented Jan 4, 2017

Ok. But are you any closer to concluding on the structure of non-personal contacts?
As it is, they are not included in the model.

@wrygiel
Copy link
Contributor

wrygiel commented Jan 4, 2017

But are you any closer to concluding on the structure of non-personal contacts?

You mean "how certain am I that XSDs won't change"?

@kaiqu
Copy link
Author

kaiqu commented Jan 4, 2017

But are you any closer to concluding on the structure of non-personal contacts?

You mean "how certain am I that XSDs won't change"?

No, I mean "do you have a suggestion or tentative conclusion"?

@wrygiel
Copy link
Contributor

wrygiel commented Jan 5, 2017

I'm not sure if I understand your question, but currently the XSDs use abstract contacts only. I'm quite certain that we need both personal and non-personal ones in the model, but both of them are currently represented using the same abstract view in XSD.

Of course, we can add more fields to this abstract view, allowing the reader to easily detect programmatically if the contact is personal or not - is this what you're missing?

@kaiqu
Copy link
Author

kaiqu commented Jan 5, 2017

After some thought, I have renamed the Coordinator entity to Contact/Fact Sheet, and generalized it to include both personal and non-personal contacts, as well as fact sheet information. I think this solves the problem, and it also obviates all the Address and URL attributes that have been cluttering up the diagram.
Posting a new version of the model soon...

@kaiqu kaiqu closed this as completed Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants