-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pybind11: merge CMake and setuptools version #45
Comments
From what I've read, this is largely a deficiency in pybind11: where the neccessary CMake files should be produced with a setuptools installation but are not. There is a mini project that fixes this in https://github.com/pybind/cmake_example, but is incompatible with hashdist because of a dependency on the pybind11 submodule. |
@zhang-alvin thanks, then we can keep our current workaround with 2 separate pybind11 installs, leave that issue open, and fix it when the problem is solved on the pybind11 repo itself |
Sounds good. Although to clarify, hashdist does have some logic to handle submodules, but I'm not sure how it's supposed to be setup since the repositories are usually downloaded as bare repositories in the |
@tridelat you can try modifying the hashdist profile_links stage as below: extends: [cmake_package] dependencies: sources:
defaults: build_stages:
profile_links:
|
Currently, we build pybind11 from CMake for xtensor-python (
pybind11_cmake.yaml
), but also from setuptools so that it is importable from python (pybind11.yaml
).We need instead to:
pybind11.yaml
andpybind11_cmake.yaml
The text was updated successfully, but these errors were encountered: