Fix: Drop support for PHP 7.4 #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
force-pushed
the
fix/php7.4
branch
from
02eff63 to
adbaa34
Compare
Codecov Report
@@ Coverage Diff @@
## main #998 +/- ##
============================================
+ Coverage 88.46% 88.52% +0.06%
Complexity 55 55
============================================
Files 4 4
Lines 182 183 +1
============================================
+ Hits 161 162 +1
Misses 21 21
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
localheinz
force-pushed
the
fix/php7.4
branch
from
adbaa34 to
c92ad68
Compare
jrfnl
added a commit
to jrfnl/composer-install
that referenced
this pull request
Dec 11, 2022
Looks like the `composer-normalize` package has dropped support for PHP < 8.0 as of version `2.29.0`. Refs: * https://github.com/ergebnis/composer-normalize/releases/tag/2.29.0 * ergebnis/composer-normalize#998
7 tasks
jrfnl
added a commit
to jrfnl/composer-install
that referenced
this pull request
Dec 20, 2022
Looks like the `composer-normalize` package has dropped support for PHP < 8.0 as of version `2.29.0`. Refs: * https://github.com/ergebnis/composer-normalize/releases/tag/2.29.0 * ergebnis/composer-normalize#998
ramsey
pushed a commit
to ramsey/composer-install
that referenced
this pull request
Jan 2, 2023
* GH Actions: selectively use `fail-fast` with setup-php I've seen some recent build failures due to the `setup-php` action running into a rate limit and not downloading the required version of Composer. In the case of this action, that would make the test runs worthless. The `setup-php` action runner defaults to _showing_ these type errors in the logs, but not stopping the workflow run. So, specifically for those jobs where the Composer version is important, I'm adding the `fail-fast` option to `setup-php` to fail the build if the action runner ran into any errors. Ref: https://github.com/shivammathur/setup-php#fail-fast-optional * GH Actions: update PHP version for `composer-normalize` Looks like the `composer-normalize` package has dropped support for PHP < 8.0 as of version `2.29.0`. Refs: * https://github.com/ergebnis/composer-normalize/releases/tag/2.29.0 * ergebnis/composer-normalize#998 Co-authored-by: jrfnl <jrfnl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request