Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with phpunit 9.x #291

Closed
mvorisek opened this issue Jul 9, 2023 · 6 comments · Fixed by #341
Closed

Compatibility with phpunit 9.x #291

mvorisek opened this issue Jul 9, 2023 · 6 comments · Fixed by #341
Assignees
@localheinz
Labels
enhancement

Comments

@mvorisek
Copy link
Contributor

mvorisek commented Jul 9, 2023 •
edited
Loading

This is a feature request. Please make this package compatible with phpunit 9.x so it can be used in projects that still need to support phpunit 9.x which is still very popular - https://packagist.org/packages/phpunit/phpunit/stats (about 70% market share).

image
@localheinz localheinz self-assigned this Jul 9, 2023
@localheinz
Copy link
Member

@mvorisek

Please convince @johnkary instead to merge johnkary/phpunit-speedtrap#98.

@localheinz localheinz closed this as not planned Won't fix, can't repro, duplicate, stale Jul 9, 2023
@mvorisek
Copy link
Contributor Author

mvorisek commented Jul 9, 2023

I am aware of that PR, but this package seems to be well tested and maintained, so adding backcompatibility should not be that hard and can help this package become popular 🚀

@localheinz
Copy link
Member

@mvorisek

Let me think about it!

@mvorisek
Copy link
Contributor Author

mvorisek commented Oct 1, 2023

@localheinz I would really appretiate it, we need to support phpunit 9 & 10 via single dep

@mvorisek mvorisek mentioned this issue Oct 1, 2023
Merged
@localheinz localheinz reopened this Oct 1, 2023
@localheinz localheinz mentioned this issue Oct 10, 2023
Merged
1 task
This was referenced Nov 1, 2023
Merged
Merged
Merged
Merged
Merged
@localheinz
Copy link
Member

Released as ergebnis/phpunit-slow-test-detector:2.4.0 - would be happy to find out it works for you, @mvorisek!

@mvorisek
Copy link
Contributor Author

mvorisek commented Nov 7, 2023

Awesome news, thank you @localheinz ❤️

@localheinz localheinz mentioned this issue Nov 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@localheinz localheinz

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhancement: Add support for phpunit/phpunit:^9.6.0 ergebnis/phpunit-slow-test-detector
2 participants
@localheinz @mvorisek