Accounting for unparsed header bytes #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Candidate for 5.0.21 release
… new Header structure field description
kushti
requested review from
ccellado,
pragmaxim,
ergomorphic,
jellymlg and
ApexTheory
ccellado
approved these changes
Apr 24, 2024
jellymlg
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2150
Currently , adding new header bytes is supported by header serialization, but unparsed bytes are not stored in Header, thus roundtrip property is broken. There is need to add unparsed bytes to Header and then at some point in when nearly all the nodes are updated it will be secure to add new bytes.
This done in this PR, with new bytes being accounted by clients >= 5.0.22 version only after 7.0 protocol activation (so 7.0 would be breaking for clients < 5.0.22)