Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate CI to GA #710

Merged
merged 23 commits into from
Dec 23, 2020
Merged

Migrate CI to GA #710

merged 23 commits into from
Dec 23, 2020

Conversation

greenhat
Copy link
Member

@greenhat greenhat commented Dec 22, 2020 •
edited
Loading

  • publish snapshot;
  • setup coverage;
  • fix uploading of coverage report;
  • switch to sbt-dynver for version generation;
  • setup release publishing;
  • test release publishing (log);
  • delete .travis.yml;

Changes

On every pull request/push run tests and publish snapshot afterwards. Versioning is switched to sbt-dynver resulting in more human-friendly versions (e.g 3.3.4-RC4-3-f02533d5-SNAPSHOT).
Release publishing is triggered by Github release. See CONTRIBUTING.md for details

@coveralls
Copy link

coveralls commented Dec 22, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 5403

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 34.624%
Files with Coverage Reduction New Missed Lines %
library-impl/src/main/scala/special/collection/CollsOverArrays.scala 1 41.95%
sigmastate/src/main/scala/org/ergoplatform/JsonCodecs.scala 1 48.39%
Totals Coverage Status
Change from base Build 5306: 0.0%
Covered Lines: 5707
Relevant Lines: 16483
💛 - Coveralls

@codecov-io
Copy link

codecov-io commented Dec 23, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@a116e37). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #710   +/-   ##
==========================================
  Coverage           ?   69.48%           
==========================================
  Files              ?      239           
  Lines              ?    17234           
  Branches           ?      531           
==========================================
  Hits               ?    11975           
  Misses             ?     5259           
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a116e37...519215b. Read the comment docs.

@greenhat
Copy link
Member Author

greenhat commented Dec 23, 2020 •
edited
Loading

@aslesarenko Due to a problem with uploading the report to coveralls (1264 ,632) I decided to give codecov a try. Check them out. I think they are on par with coveralls feature-wise.

EDIT: Upload step failed with [error] Uploading to https://coveralls.io failed: Couldn't find a repository matching this job. although I regenerated and used proper coveralls repo token.

@greenhat greenhat marked this pull request as ready for review December 23, 2020 11:49
@greenhat greenhat requested a review from aslesarenko December 23, 2020 14:58
@greenhat
Copy link
Member Author

greenhat commented Dec 23, 2020 •
edited
Loading

@aslesarenko Although I removed .travis.yml Github still waits for Travis. To get rid of this Travis webhook should be removed in https://github.com/ScorexFoundation/sigmastate-interpreter/settings/hooks killing Travis jobs in all open PRs, so I suggest to do it after this PR is merged and it's changes are propagated into open PRs.

@aslesarenko aslesarenko merged commit 973f850 into develop Dec 23, 2020
@aslesarenko aslesarenko deleted the migrate-ci-tests-to-ga branch December 24, 2020 08:57
@aslesarenko aslesarenko mentioned this pull request Jan 5, 2021
Merged
scalahub pushed a commit that referenced this pull request Apr 20, 2021
@greenhat @scalahub
Migrate CI to GA (#710)
9c0a044 
* add sbt-github-actions plugin, upgrade sbt to 1.4.5;

* fix crossScalaVersions;

* restore crossScalaVersions for all projects;

* remove sbt-github-actions plugin;

add publish step to

* remove clean.yml;

* add tags to ignore (starting with "v");

* combine coverage report generation with test run;

* remove tags-ignore;

* remove snapshot publishing on Travis;

* add COVERALLS_REPO_TOKEN env var;

* switch from sbt-git to sbt-dynver for 'version';

* add release.yml workflow;

* rename main GA workflow to CI;

* run coverageReport under matrix scala version;

* remove .travis.yml;

split code coverage collection and report uploading;

* switch to codecov;

* add cache to release.yml workflow;

* fix import_gpg.sh permissions, add java version to release.yml;

* add required SCM url be Sonatype;

* add CONTRIBUTING.md with instructions on how to make a release;

* update sbt-sonatype plugin;

* fix release.yml step name;

* delete .travis.jvmopts;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslesarenko aslesarenko aslesarenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@greenhat @coveralls @codecov-io @aslesarenko