[6.0.0] Header.checkPow method #968
Conversation
|
JS test was failing due to #1023 , fixed now |
| @@ -1313,6 +1313,9 @@ case class MethodCall( | |||
| addCost(MethodCall.costKind) // MethodCall overhead | |||
| method.costKind match { | |||
| case fixed: FixedCost => | |||
| if (method.sinceVersion > 0 && E.context.currentErgoTreeVersion < method.sinceVersion) { | |||
| syntax.error(s"Method ${method.name} is not supported in tree version ${E.context.currentErgoTreeVersion}") | |||
| } | |||
There was a problem hiding this comment.
This will be the first code fragment versioned by tree version (rather than activatedVersion). Maybe use activatedVersion instead? dApps usually don't care about versions, and hence requiring a minimal tree version may require dApp upgrades.
There was a problem hiding this comment.
Possible, however, there are some questions to resolve then :
- NewFeature implementation by you was expecting this:
override def isSupportedIn(vc: VersionContext): Boolean =
vc.activatedVersion >= sinceVersion && vc.ergoTreeVersion >= sinceVersion
why ?
- what does tree version mean at all ? How tree of version v+1 is different from tree version v?
There was a problem hiding this comment.
Rollback versioning by tree and changed NewFeature definition. The question about versioning semantics still remains.
There was a problem hiding this comment.
This "vc.activatedVersion >= sinceVersion && vc.ergoTreeVersion >= sinceVersion" was an intermediate version, which was fixed in the in my original more recent PRs.
The tree version is more about bytecode format, see for example switch from v0, to v1, there size has become required. However, there is also a relation between tree version and block version, s.t. treeVersion <= activatedScriptVersion.
data/shared/src/main/scala/sigma/pow/Autolykos2PowValidation.scala
Outdated
Show resolved
Hide resolved
|
@aslesarenko comments addressed, please make another pass |
In this PR, a new method added to check Ergo header's proof-of-work