[6.0.0] Support Header (de)serialization #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslesarenko
requested changes
Jun 10, 2024
interpreter/shared/src/test/scala/sigma/serialization/SerializationSpecification.scala
Outdated
Show resolved
Hide resolved
interpreter/shared/src/test/scala/sigma/serialization/generators/ObjectGenerators.scala
Show resolved
Hide resolved
sdk/shared/src/test/scala/org/ergoplatform/sdk/DataJsonEncoderSpecification.scala
Outdated
Show resolved
Hide resolved
sdk/shared/src/test/scala/org/ergoplatform/sdk/DataJsonEncoderSpecification.scala
Outdated
Show resolved
Hide resolved
|
@ergomorphic comments addressed, please make another pass! |
1 similar comment
|
@ergomorphic comments addressed, please make another pass! |
aslesarenko
requested changes
Jun 12, 2024
|
@ergomorphic comments addressed, please make another pass! |
|
@ergomorphic comments addressed, please make another pass! |
aslesarenko
reviewed
Aug 5, 2024
|
@aslesarenko comments addressed, please make another pass! |
aslesarenko
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, versioned (for Sigma >=6.0) Header type (de)serialization is implemented.
For that, ErgoHeader from Ergo codebase, its serializer and related classes and their respective serializers are copied from the original repository. Thus there is a need to import those classes from Sigma in future versions of Ergo node codebase, see ergoplatform/ergo#2163
close #969