Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.0] Fix SubstConstants: serialize ErgoTree size #995

Merged
merged 23 commits into from
Aug 5, 2024
Merged

[6.0] Fix SubstConstants: serialize ErgoTree size #995

merged 23 commits into from
Aug 5, 2024

Conversation

aslesarenko
Copy link
Member

@aslesarenko aslesarenko commented May 22, 2024 •
edited
Loading

Closes #994

@aslesarenko aslesarenko marked this pull request as ready for review May 22, 2024 19:54
@aslesarenko aslesarenko linked an issue May 23, 2024 that may be closed by this pull request
Fix SubstContants: serialize ErgoTree size #994
Open
@aslesarenko aslesarenko self-assigned this May 25, 2024
@aslesarenko aslesarenko requested a review from kushti June 5, 2024 13:09
@kushti kushti changed the base branch from v6.0-serialize to v6.0-newfeature June 7, 2024 09:22
@kushti kushti changed the base branch from v6.0-newfeature to v6.0-serialize June 7, 2024 09:50
@kushti kushti changed the base branch from v6.0-serialize to v6.0-newfeature June 7, 2024 10:05
kushti
kushti requested changes Jun 7, 2024
View reviewed changes
Copy link
Member

@kushti kushti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains serious changes to another 6.0 method, serialize ( introducing CheckMinimalErgoTreeVersion rule). Those changes should be moved to corresponding PR.

@kushti kushti mentioned this pull request Jun 7, 2024
Merged
@kushti kushti force-pushed the v6.0-newfeature branch from 07b8644 to e7bd2a3 Compare June 8, 2024 18:49
Base automatically changed from v6.0-newfeature to v6.0.0 June 9, 2024 08:53
aslesarenko
aslesarenko commented Jun 12, 2024
View reviewed changes
Copy link
Member Author

@aslesarenko aslesarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please address comments and consider it approved (github doesn't allow approval of own PR)

sc/shared/src/test/scala/sigmastate/lang/SigmaBinderTest.scala Outdated
@@ -31,9 +31,6 @@ class SigmaBinderTest extends AnyPropSpec with ScalaCheckPropertyChecks with Mat
res
}

/** Checks that parsing and binding results in the expected value.
* @return the inferred type of the expression
*/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the scaladoc is removed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restored

@aslesarenko aslesarenko requested a review from kushti June 12, 2024 15:26
@kushti kushti merged commit 2a3c72d into v6.0.0 Aug 5, 2024
4 checks passed
@kushti kushti deleted the i994-fix-subst-constants branch August 5, 2024 17:03
This was referenced Aug 5, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushti kushti kushti approved these changes

Assignees

@aslesarenko aslesarenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix SubstContants: serialize ErgoTree size
2 participants
@aslesarenko @kushti