You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I want to propose a couple changes to the Ristretto API. I'm happy to try make these changes and create a pull request if the main contributors think this is a good idea.
Rather than name methods compute_rx where x is the name of the non-randomized method, what about just rx? For example, rsvd instead of compute_rsvd, rlu instead of compute_rlu. This would match libraries like NumPy, but with an r prefix to indicate it is a randomized version.
Rather than importing from modules named ristretto.x where x is the name of the non-randomized method, import directly from ristretto. For example, rather than importing from ristretto.cur, import directly from ristretto.
As an example of combining these two changes, instead of,
>>> from ristretto.svd import compute_rsvd
we would have,
>>> from ristretto import rsvd
The text was updated successfully, but these errors were encountered:
Originally, that was the way the API was designed. However, as a project we are moving to support Scikit-learn compatible estimators (#28) and have such chosen to rename the functions with the compute_ prefix and the compelementary classes as the upper case abbreviation (ie compute_rdmd and RDMD).
@gwgundersen thanks a lot for your suggestion. Personally, I favor the API you suggested! But, as @jknox13 said, we try to push the package into a direction so that it can be integrated into standard ML pipelines. Anyway, we always need help and contributions are very welcome. If you have any good ideas or if you like to add new features, feel free to push or to drop as a mail.
I want to propose a couple changes to the Ristretto API. I'm happy to try make these changes and create a pull request if the main contributors think this is a good idea.
Rather than name methods
compute_rx
wherex
is the name of the non-randomized method, what about justrx
? For example,rsvd
instead ofcompute_rsvd
,rlu
instead ofcompute_rlu
. This would match libraries like NumPy, but with anr
prefix to indicate it is a randomized version.Rather than importing from modules named
ristretto.x
wherex
is the name of the non-randomized method, import directly fromristretto
. For example, rather than importing fromristretto.cur
, import directly fromristretto
.As an example of combining these two changes, instead of,
we would have,
The text was updated successfully, but these errors were encountered: