-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React to changes in Alpine RID graph #214
Comments
Acknowledged. I assume that you need this fairly soon? |
Don't feel rushed on this one. The workaround is fairly simple for us. But, if you have time to get this in the next few weeks, that would be great. For some context: aspnet/Universe#1104, aspnet/Universe#1101 |
Very good. Thanks. |
@natemcmaster So my only reason for delay here is that releasing a 1.1.11 which contains nothing but this change seems kinda sad. I figured if I stalled a little bit, another trivial change might arrive, and then I would have two, which would be half as sad. I thought about various ways to change my build system to be more flexible in accommodating a situation like this. I conclude that I definitely need to revamp the build system, for a variety of reasons, but now is not the time. So, unless you have other concerns, I plan to just go ahead with a 1.1.11, probably in the next few days. |
That would be great. We're almost in escrow for 2.1.0 RTM. It may actually be beneficial to getting this in as a last minute change if the package layout is the only thing that changed in this patch. By the way, I thought about this a little more. To keep .NET Core 2.0 customers happy, it might be better to put the libe_sqlite3.so file in both "runtimes/alpine-x64" and "runtimes/linux-musl-x64". It makes me sad this is necessary, but .NET Core 2.0 apps won't know how to treat "linux-musl-x64" yet, only .NET Core 2.1+ |
I tweaked the package layout as you just described, putting the same libe_sqlite3.so file in both alpine-x64 and linux-musl-x64. I am pushing 1.1.11 to nuget now. The package layout described herein is the only change. Well, to be pedantic, the version number also changed, which means:. All the assemblies got rebuilt, with the AssemblyVersion updated. So the assemblies in these nuget packages are not the exact same bits as 1.1.10, but they were built from the same code on the same machine using the same build script calling the same tooling, all of which have been quite trustworthy. |
Awesome, thanks @ericsink. I'll get a PR ready to aspnetcore to consume this update. |
Tested and updated to 1.1.11. Thanks again for fixing this! |
Starting in .NET Core 2.1, there is a new parent rid for
alpine-x64
calledlinux-musl-x64
(see dotnet/corefx#28560). #192 added Alpine support (thanks again). To make this available to other Linux distros based on muslc-based SQLite, I'd recommend the following, fairly minor change:runtimes/alpine-x64/
toruntimes/linux-musl-x64/
.If you want to keep the package backwards compatible with .NET Core 2.0 and earlier, you can either..
Microsoft.NETCore.Platforms
2.1.0 or greater. (This magic package defines the alpine-x64->linux-musl-x64 relationship)The text was updated successfully, but these errors were encountered: