Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools/c-globals/check-c-statics.py should pass without any ignored globals. #48

Open
3 tasks
ericsnowcurrently opened this issue Jun 21, 2019 · 0 comments
Open
3 tasks
Labels
complexity: medium moderately hard to figure out P1 medium priority size: large requires a lot of changes status: blocked waiting for another issue type: code health URGENT must be dealt with ASAP X [isolation] improved interpreter isolation X [runtime] CPython runtime (lifecycle, state)

Comments

@ericsnowcurrently
Copy link
Owner

ericsnowcurrently commented Jun 21, 2019

(blocked by #47)

When check-c-globals.py runs it fails if it finds any static variables that it determines should not actually be global (e.g. hold per-interpreter runtime state). Currently have a fixed list of globals that we ignore, which would otherwise cause the script to fail. It needs to pass without such a list.

That list is stored in Tools/c-globals/ignored-globals.txt (or its replacement, e.g. Tools/c-analyzer/c_statics/ignored.tsv).

Here are the concrete steps we need to take:

  • resolve each unsupported variable found by Tools/c-analyzer/c-statics.py
  • stop using the --ignored arg in Lib/test/test_check_c_statics.py
  • remove the Tools/c-analyzer/c_statics/ignored.tsv file
@ericsnowcurrently ericsnowcurrently added X [isolation] improved interpreter isolation X [runtime] CPython runtime (lifecycle, state) P1 medium priority type: code health status: blocked waiting for another issue size: large requires a lot of changes complexity: medium moderately hard to figure out labels Jun 21, 2019
@ericsnowcurrently ericsnowcurrently changed the title Tools/c-globals/check-c-globals.py should pass without any ignored globals. Tools/c-globals/check-c-statics.py should pass without any ignored globals. Jul 5, 2019
@ericsnowcurrently ericsnowcurrently added the URGENT must be dealt with ASAP label Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: medium moderately hard to figure out P1 medium priority size: large requires a lot of changes status: blocked waiting for another issue type: code health URGENT must be dealt with ASAP X [isolation] improved interpreter isolation X [runtime] CPython runtime (lifecycle, state)
Projects
None yet
Development

No branches or pull requests

1 participant