Tools/c-globals/check-c-statics.py
should pass without any ignored globals.
#48
Labels
complexity: medium
moderately hard to figure out
P1
medium priority
size: large
requires a lot of changes
status: blocked
waiting for another issue
type: code health
URGENT
must be dealt with ASAP
X [isolation]
improved interpreter isolation
X [runtime]
CPython runtime (lifecycle, state)
(blocked by #47)
When
check-c-globals.py
runs it fails if it finds any static variables that it determines should not actually be global (e.g. hold per-interpreter runtime state). Currently have a fixed list of globals that we ignore, which would otherwise cause the script to fail. It needs to pass without such a list.That list is stored in
Tools/c-globals/ignored-globals.txt
(or its replacement, e.g.Tools/c-analyzer/c_statics/ignored.tsv
).Here are the concrete steps we need to take:
Tools/c-analyzer/c-statics.py
--ignored
arg inLib/test/test_check_c_statics.py
Tools/c-analyzer/c_statics/ignored.tsv
fileThe text was updated successfully, but these errors were encountered: