Set track recording buffer to exact length #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericyd
commented
Nov 25, 2022
Comment on lines
+140
to
+146
| // 60 seconds beats 60 seconds minute | ||
| // ———————————— ➗ ————— 🟰 ——————————— 𝒙 ——————— => | ||
| // minute minute minute beats | ||
| // | ||
| // seconds minutes measures beats samples samples | ||
| // ————————— 𝒙 ———————— 𝒙 ———————— 𝒙 ———————— 𝒙 ————————— 🟰 —————————— | ||
| // minute beat loop measure second loop |
There was a problem hiding this comment.
for some reason this doesn't align super well in my editor compared to github... seems like a weird font issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the "recordingLength" from the recording processor does not typically equate to the length of the loop. It is often very close, but not precisely equal.
For one or two loops, the discrepancy is hard to detect, but over many loops the loop drifts substantially behind the beat and it becomes impossible to play along.
This fixes that issue