Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor props tree #28

Merged
merged 17 commits into from
Dec 6, 2022
Merged

Refactor props tree #28

merged 17 commits into from
Dec 6, 2022

Conversation

ericyd
Copy link
Owner

@ericyd ericyd commented Dec 5, 2022

  • Move clock Worker into own component. Place it at the top of the tree and pass it to all children
  • Properly use dependency arrays in useEffect hooks
  • Move encapsulated functionality into separate components
    • Exporter component handles exporting a track's audio
    • BeatCounter fully encapsulates the process of updating the counter component, so children don't get re-rendered on every beat
  • rename worklets to workers; this directory had 3 workers and 1 worklet, it only seemed fair
  • use named exports everywhere, rather than defaults (weird preference thing)
  • fix bug where track muting wasn't carrying over between loops

@ericyd ericyd force-pushed the track-bugs-rerenders-effects branch from e7eae06 to 7d15fcf Compare December 6, 2022 16:47
@ericyd ericyd merged commit 3d3cf38 into main Dec 6, 2022
@ericyd ericyd deleted the track-bugs-rerenders-effects branch December 6, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant