Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recording settings (define constraints) #30

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Conversation

ericyd
Copy link
Owner

@ericyd ericyd commented Dec 8, 2022

  • Define constraints on audio when getting user media. This doesn't make sense why this is required, but it makes the recording actually work on my audio interface, whereas previously the audio would fade in and out inexplicably.
  • Create the track's stream on track mount, rather than on Start. This makes properties a bit easier to pass around, and prevents re-using the same stream for multiple tracks. I'm not sure this is illegal, but this felt like a better approach

@ericyd ericyd merged commit 163563e into main Dec 8, 2022
@ericyd ericyd deleted the fix-recording-settings branch December 8, 2022 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant