Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metronome garbage cleanup #31

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Metronome garbage cleanup #31

merged 2 commits into from
Dec 9, 2022

Conversation

ericyd
Copy link
Owner

@ericyd ericyd commented Dec 9, 2022

  • disconnect GainNodes that are created in Metronome, if the audioContext changes
  • do not create a GainNode inside useRef; create it in useEffect
  • disconnect AudioBufferSourceNode on each tick, if it exists

@ericyd ericyd merged commit 1924a68 into main Dec 9, 2022
@ericyd ericyd deleted the metronome-garbage-cleanup branch December 9, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant