Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Metronome props to Track; calculated recording length #38

Merged
merged 5 commits into from
Dec 14, 2022
Merged

Conversation

ericyd
Copy link
Owner

@ericyd ericyd commented Dec 14, 2022

Major

  • move Scene and Track under Metronome, and pass key Metronome props to Scene + Track
  • revert to a calculated "recording length", based on metronome props, instead of using the reported recording length from the recorder worklet

Minor

  • update console calls to logger (except in the export worker which doesn't have access to the window global)
  • refactor "useDecayingSine" to the hooks directory, and rename hook

@ericyd ericyd merged commit c06e81a into main Dec 14, 2022
@ericyd ericyd deleted the refactoring branch December 14, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant