Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buffer creation #39

Merged
merged 7 commits into from
Dec 14, 2022
Merged

Update buffer creation #39

merged 7 commits into from
Dec 14, 2022

Conversation

ericyd
Copy link
Owner

@ericyd ericyd commented Dec 14, 2022

  • use half of the recording latency as the buffer offset. Not sure why half the reported latency sounds good but it seems to!
  • instead of just dropping the part of the audio that would normally be trimmed due to latency, stick it on the end of the buffer. In theory, if the first part of the buffer contained a transient, this might allow the transient to hit at the very end of the loop and "connect" back to the beginning. 🤷🏻 It's a little bit of a shot in the dark, but it didn't seem to harm anything

@ericyd ericyd merged commit 7c872bd into main Dec 14, 2022
@ericyd ericyd deleted the start-of-buffer-goes-to-end branch December 14, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant