Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add early return in ComputeTxEnv for state sync transactions #12315

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Add early return in ComputeTxEnv for state sync transactions #12315

merged 2 commits into from
Oct 15, 2024

Conversation

shohamc1
Copy link
Member

@shohamc1 shohamc1 commented Oct 15, 2024 •
edited
Loading

ComputeTxEnv relied on txIndex < len(block.Transactions()) which is violated by Polygon's state sync event transaction. We handle this case by adding an early return for this case, returning only ibs and blockContext which is used during state sync event tracing.

Fixes #11701, #12007

@shohamc1 shohamc1 mentioned this pull request Oct 15, 2024
Merged
@shohamc1 shohamc1 added this to the 2.60.9-fixes milestone Oct 15, 2024
@AskAlexSharov AskAlexSharov merged commit 9a73c4a into release/2.60 Oct 15, 2024
5 checks passed
@AskAlexSharov AskAlexSharov deleted the shohamc1/fix-debug-crash branch October 15, 2024 08:28
taratorio pushed a commit that referenced this pull request Oct 15, 2024
@shohamc1
Add early return in ComputeTxEnv for state sync transactions (#12316)
ae68dc0 
Port #12315 for Erigon 3
@shohamc1 shohamc1 mentioned this pull request Oct 16, 2024
Merged
shohamc1 added a commit that referenced this pull request Oct 18, 2024
@shohamc1
rpcdaemon: Only allow large txIndex for state sync transactions (#12342)
add87c8 
Refinement from #12315 as this condition should only be allowed under
certain cases.
yperbasis pushed a commit that referenced this pull request Oct 24, 2024
@shohamc1 @yperbasis
Add early return in ComputeTxEnv for state sync transactions (#12315)
8b103fe 
`ComputeTxEnv` relied on `txIndex < len(block.Transactions())` which is
violated by Polygon's state sync event transaction. We handle this case
by adding an early return for this case, returning only ibs and
blockContext which is used during state sync event tracing.

Fixes #11701, #12007
@yperbasis yperbasis mentioned this pull request Oct 24, 2024
Merged
yperbasis added a commit that referenced this pull request Oct 24, 2024
@yperbasis @shohamc1
Add early return in ComputeTxEnv for state sync transactions (#12447)
8b3a532 
Cherry pick #12315 into `release/2.61`

Co-authored-by: Shoham Chakraborty <shhmchk@gmail.com>
yperbasis pushed a commit that referenced this pull request Oct 24, 2024
@shohamc1 @yperbasis
rpcdaemon: Only allow large txIndex for state sync transactions (#12342)
c2a9cab 
Refinement from #12315 as this condition should only be allowed under
certain cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AskAlexSharov AskAlexSharov AskAlexSharov approved these changes

@antonis19 antonis19 Awaiting requested review from antonis19

@taratorio taratorio Awaiting requested review from taratorio

@mh0lt mh0lt Awaiting requested review from mh0lt

Assignees
No one assigned
Labels
polygon
Projects
None yet
Milestone
2.60.9-fixes
Development

Successfully merging this pull request may close these issues.
2 participants
@shohamc1 @AskAlexSharov