Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updateForkChoice: support --sync.loop.block.limit #9315

Merged
merged 1 commit into from
Jan 28, 2024
Merged

updateForkChoice: support --sync.loop.block.limit #9315

merged 1 commit into from
Jan 28, 2024

Conversation

AskAlexSharov
Copy link
Collaborator

No description provided.

Giulio2002
Giulio2002 approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@Giulio2002 Giulio2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think it should not fuck up too much the flow

@AskAlexSharov AskAlexSharov merged commit 3591046 into devel Jan 28, 2024
7 checks passed
@AskAlexSharov AskAlexSharov deleted the fork_choice_jump_limit branch January 28, 2024 02:43
@AskAlexSharov AskAlexSharov mentioned this pull request Jan 28, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Feb 22, 2024
Closed
yperbasis added a commit that referenced this pull request Mar 28, 2024
@yperbasis
Revert "updateForkChoice: support --sync.loop.block.limit (#9315)"
d5bfbe7
@yperbasis yperbasis mentioned this pull request Mar 28, 2024
Merged
yperbasis added a commit that referenced this pull request Mar 28, 2024
@yperbasis
Revert "updateForkChoice: support --sync.loop.block.limit (#9315)" (#…
a013ec2 
…9833)

Revert PR #9315 since it apparently causes MDBX bloat and performance
regression. The regression was introduced in
[v2.58.0](https://github.com/ledgerwatch/erigon/releases/tag/v2.58.0).
awskii pushed a commit that referenced this pull request Apr 11, 2024
@AskAlexSharov @yperbasis
Revert "updateForkChoice: support --sync.loop.block.limit (#9315)" (#…
a5d82cf 
…9900)

we have this PR in release and don't have in devel

Co-authored-by: Andrew Ashikhmin <34320705+yperbasis@users.noreply.github.com>
Kakkarrot pushed a commit to covalenthq/erigon that referenced this pull request Apr 17, 2024
@yperbasis @Kakkarrot
Revert "updateForkChoice: support --sync.loop.block.limit (erigontech…
1ade0b5 
…#9315)" (erigontech#9833)

Revert PR erigontech#9315 since it apparently causes MDBX bloat and performance
regression. The regression was introduced in
[v2.58.0](https://github.com/ledgerwatch/erigon/releases/tag/v2.58.0).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Giulio2002 Giulio2002 Giulio2002 approved these changes

@elee1766 elee1766 Awaiting requested review from elee1766

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AskAlexSharov @Giulio2002