rpcdaemon: fix mismatch in erigon_getHeaderBy[Hash|Number] #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lupin012
force-pushed
the
fix_erigon_getHeader
branch
from
5c3d9a7
to
afacc07
Compare
canepat
changed the title
canepat
added
the
maintenance
canepat
approved these changes
Oct 29, 2024
canepat
reviewed
Oct 29, 2024
| @@ -957,7 +957,7 @@ Task<void> EthereumRpcApi::handle_eth_get_balance(const nlohmann::json& request, | |||
| reply = make_json_content(request, "0x" + (account ? intx::hex(account->balance) : "0")); | |||
| } catch (const std::exception& e) { | |||
| SILK_ERROR << "exception: " << e.what() << " processing request: " << request.dump(); | |||
| reply = make_json_error(request, kInternalError, e.what()); | |||
| reply = make_json_content(request, "0x0"); | |||
There was a problem hiding this comment.
This should be investigated more: it's far from ideal to return just zero balance if any exception happens on the node
canepat
added
json rpc api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.