redux-thunk compatibility

[jmarceli]

For regular redux reducer action I can return a function. Example:

export function fetchDataIfNeeded() {
  return (dispatch, getState) => {
    if (shouldFetchData(getState(), storeName)) {
      return dispatch(fetchData())
    } else {
      return Promise.resolve()
    }
  }
}

Is it possible also with multireducer? How?

I've tried code above but with no luck. Returned function was never executed.

[adailey14]

I just created a fork of this project that does things a bit differently and allows for use with thunk middleware (but you have to manually pass in the multireducerKey when using thunks so not amazing). It also changes the semantics of the project a bit to be closer to connect() and bindActionCreators(), and allows for multiple mountpoints. I needed this for a project I'm working on. Here is the link:

https://github.com/adailey14/multireducer

@erikras please take a look and let me know if you'd like me to make a pull request or anything. I haven't contributed to much open source on github so you'll have to let me know exactly how to do that. This would break backwards-compatability for the repo though so maybe you won't want to.

[jmarceli]

Looks nice. I manage to solve my problem without multi reducer (by making reducer class) but your solution is much cleaner than mine. I'll probably try to use it in my next project.

[adailey14]

Thanks @jmarceli. I just did a bit of a rewrite and figured out how to make thunks work with no extra effort, which is so much better. The trick was taking over dispatch so that it wraps any dispatched actions with the multireducerKey, and wraps any 'thunk' action creators inside another thunk that passes them the modified dispatch.

@erikras let me know when you have a chance to check it out - we could probably make it backwards compatible without too much effort and merge it back into this repo if you want to.

[jsdmc]

multireducer definitely needs redux-thunk support. It's common case to use thunk actions in redux-apps, so it should be possible to use them in actions that are handled by multireducer

[Elyx0]

Same issue here, did @adailey14 do a PR for this ?

[adailey14]

Sorry, i never did a PR. I am using that project fork for a personal project, and I think it probably diverged too much from this to do a clean PR. Feel free to jump into that code and put together a PR if you're so inclined!

[jsdmc]

Hi guys.
@adailey14 I took your changes and added some mine as well.
@erikras I also used some code from redux-form (wrapMapStateToProps, wrapMapDispatchToProps)
https://github.com/jsdmc/multireducer

Can you pls check example of usage (http://localhost:3000/countersPage) and we can discuss API
https://github.com/jsdmc/react-redux-router-crud-boilerplate/tree/multireducer

Cheers

[netpoetica]

I hate a be a plus-oner, but this would be incredibly useful. Setting this up with redux-thunk or redux-actions as middleware is essential

[erikras]

I'd be willing to accept a PR, but I don't have the time to code it myself.

[jsdmc]

submitted PR #103

[adailey14]

👍