Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON.stringify() security issue #42

Closed
donabrams opened this issue Jul 21, 2015 · 1 comment
Closed

JSON.stringify() security issue #42

donabrams opened this issue Jul 21, 2015 · 1 comment

Comments

@donabrams
Copy link

JSON.stringify doesn't correctly escape </script> leading to potential client code injection. The use of a library like serialize-javascript is recommended.

Example:
https://github.com/erikras/react-redux-universal-hot-example/blob/master/src/server.js#L63

Vulnerability description:
http://benalpert.com/2012/08/03/preventing-xss-json.html

Since this is the defacto redux-hot example (minus the todo and counter), I really want to correct this here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants