Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React ref on header links #47

Closed
codepunkt opened this issue Jul 24, 2015 · 2 comments
Closed

React ref on header links #47

codepunkt opened this issue Jul 24, 2015 · 2 comments

Comments

@codepunkt
Copy link
Contributor

Theres a ref attribute on links in header, which seems unused.
Does this serve any purpose or was it forgotten?

webpackStats.css.map((css, i) => <link href={css} ref={i} media="screen, projection" rel="stylesheet" type="text/css"/>)
@erikras
Copy link
Owner

erikras commented Jul 24, 2015

I think it's supposed to be key, as that's outputting an array of components. Although I think there is usually only one so react doesn't complain.

@erikras
Copy link
Owner

erikras commented Jul 24, 2015

Thanks, @gonsfx.

@wlcdesigns wlcdesigns mentioned this issue Nov 16, 2022
Open
@neolivz neolivz mentioned this issue Nov 16, 2022
Open
@wlcdesigns wlcdesigns mentioned this issue Nov 29, 2022
Open
@neolivz neolivz mentioned this issue Nov 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codepunkt @erikras