Get image requiring working with url-loader

[erikras]

Ideally we want to use url-loader for image files to capture small files as base64 encoded strings to reduce the number of http requests to the server, but the image requiring solution that solved #39 does not work with url-loader.

Someone needs to investigate. The base64 string is probably in webpack-stats.json somewhere. It's just a matter of making requireServerImage() smart enough to use it instead.

[NogsMPLS]

FYI, base64 string is inside image.source when using url-loader. But it ends up having the whole module.exports = thing inside it.

Also, the logo image has the base64 in source, but the kitten image has a link to a .jpg named like c29770d03d2e95e3ea5899d57c6cfeab.jpg as opposed to a true base64 data:image kind of thing. Dunno fi that is an issue or working as intended though.

[erikras]

That's working as intended. It only encodes images under a certain threshold.

[NogsMPLS]

okay cool. also I think i have a fix. ill get a PR here for you to look at here in a few minutes

[NogsMPLS]

basically that fix is checking image.source,

finding the index of the first double quote ",

slicing at that point and chopping the last character(also a double quote) off.

then checks if the string starts with data:image.

if it does, then use that, if not then append publicPath to it and use that. Seems to be working for me on Windows, can't test mac.

[erikras]

Works on Mac. Well done! 👍

[leonli]

👍