Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styles broken with JS's disabled #75

Closed
goldensunliu opened this issue Jul 31, 2015 · 12 comments
Closed

styles broken with JS's disabled #75

goldensunliu opened this issue Jul 31, 2015 · 12 comments

Comments

@goldensunliu
Copy link

image

@leonli
Copy link
Contributor

leonli commented Jul 31, 2015

Are you running on dev mode?

@erikras
Copy link
Owner

erikras commented Jul 31, 2015

It should at least render properly in production mode. However, as I mentioned in #62, this project is not really designed to work with javascript disabled.

@erikras
Copy link
Owner

erikras commented Jul 31, 2015

In dev mode, the styles are injected by the script that webpack dev server injects, so you get a brief FOUC. It's the price of having the hot reloading during development.

@erikras erikras closed this as completed Jul 31, 2015
@ostrgard
Copy link

This is not just a problem with JS disabled. It results in a FOUC in production (the Heroku build does this as well), as components using non-global classes doesn't have the className set when the server renders. If you log out styles in Main.js render function, it'll be empty on server render and populated as expected on the client render.

Any ideas on to fix this?

@erikras
Copy link
Owner

erikras commented Aug 24, 2015

You are very correct. I will investigate.

@ostrgard
Copy link

Any news on this @erikras?

@erikras
Copy link
Owner

erikras commented Aug 31, 2015

Not yet. Haven't gotten around to it, sorry.

@dmitry
Copy link

dmitry commented Aug 31, 2015

@ostrgard is it possible to reproduce it on the demo site?

@erikras
Copy link
Owner

erikras commented Aug 31, 2015

@dmitry Yes, the demo site exhibits this behavior.

@ostrgard
Copy link

@dmitry This gif shows what happens on page refresh. You can disable JS to see it permanently.

@erikras
Copy link
Owner

erikras commented Aug 31, 2015

Since this project is not intended to support javascript disabled browsers, this issue will remain closed, but the FOUC is an important issue, so I've opened #153.

@ostrgard
Copy link

+1 for the title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants